[Webkit-unassigned] [Bug 86466] Web Inspector: AdvancedSearchController is not stopped then view is hidden.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=86466


Vsevolod Vlasov <vsevik at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #141918|                            |review+
               Flag|                            |




--- Comment #6 from Vsevolod Vlasov <vsevik at chromium.org>  2012-05-15 06:45:25 PST ---
(From update of attachment 141918)
View in context: https://bugs.webkit.org/attachment.cgi?id=141918&action=review

>>> Source/WebCore/inspector/front-end/AdvancedSearchController.js:360
>>> +     * @override
>> 
>> We don't use @overrride annotation because it does not catch any error (try renaming back to wasHidden and observe no compiler errors).
> 
> I've tried it before writing this annotation.
> Compiler doesn't catch this error, that's no good. But we can hope it will do some day.
> 
> BUT this annotation not only for compiler, but also for developers, because it make code a way core clear.

I don't think we should add compiler annotations for developers. We don't even add comments usually.
Please remove this for consistency.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.