[Webkit-unassigned] [Bug 86466] Web Inspector: AdvancedSearchController is not stopped then view is hidden.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=86466


Vsevolod Vlasov <vsevik at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #141918|review?                     |review+
               Flag|                            |




--- Comment #2 from Vsevolod Vlasov <vsevik at chromium.org>  2012-05-15 05:13:44 PST ---
(From update of attachment 141918)
View in context: https://bugs.webkit.org/attachment.cgi?id=141918&action=review

> Source/WebCore/ChangeLog:6
> +        AdvancedSearchController overrides "wasHidden" method instead of "willHide".

Please move this line below "Reviewed by".

> Source/WebCore/inspector/front-end/AdvancedSearchController.js:360
> +     * @override

We don't use @overrride annotation because it does not catch any error (try renaming back to wasHidden and observe no compiler errors).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.