[Webkit-unassigned] [Bug 86367] Web Inspector: Use CSS columns feature for HelpScreen contents.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=86367





--- Comment #21 from eustas.bug at gmail.com  2012-05-15 05:05:53 PST ---
(In reply to comment #17)
> (From update of attachment 141714 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=141714&action=review
> 
> >>> Source/WebCore/inspector/front-end/ShortcutsScreen.js:131
> >>> +        var i, keyCell, line;
> >> 
> >> Why extract all the variable declarations?
> > 
> > To avoid accidental duplicate declaration.
> > 
> > Variable declaration at any place inside scope is semantically equivalent to declaration at the beginning of context.
> > So explicit declaration at the beginning makes code much more clear.
> > 
> > Quote: "...the isolated scope... is created only by execution contexts with 'function' code type... in contrast with C/C++... the block of for loop... does not create a local context".
> > Reference: http://ecma262-5.com/ELS5_Section_10.htm#Section_10.3
> 
> Despite the fact that all variables are equally visible in the scope of a function body, inspector coding convention is to declare variables at the places where they are initialized.

Fixed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.