[Webkit-unassigned] [Bug 84572] [EFL] Split ewk_private.h file to multiple private files.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84572





--- Comment #18 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-05-15 00:46:12 PST ---
(From update of attachment 141877)
View in context: https://bugs.webkit.org/attachment.cgi?id=141877&action=review

There are many style nits in this patch. This style nits weren't fixed before. Can you fix style nits within no big changes?

http://trac.webkit.org/wiki/EFLWebKitCodingStyle

> Source/WebKit/efl/ewk/ewk_auth_soup_private.h:36
> +    GObject parent_instance;

Do not use _ in variable name.

> Source/WebKit/efl/ewk/ewk_auth_soup_private.h:43
> +GType ewk_auth_soup_dialog_get_type(void);

WebKit EFL adheres webkit coding style and C++ coding style except for public APIs. So, I think you need to remove void keyword in parameter.

> Source/WebKit/efl/ewk/ewk_auth_soup_private.h:50
> +void ewk_auth_soup_credentials_set(const char *username, const char *password, void *data);

Move '*' to data type side.

> Source/WebKit/efl/ewk/ewk_frame_private.h:82
> +WebCore::Frame *coreFrame(const Evas_Object *ewkFrame);

ditto.

> Source/WebKit/efl/ewk/ewk_history_private.h:31
> +Ewk_History_Item *ewk_history_item_new_from_core(WebCore::HistoryItem *core);

ditto.

> Source/WebKit/efl/ewk/ewk_history_private.h:36
> +WebCore::HistoryItem *coreHistoryItem(const Ewk_History_Item *ewkHistoryItem);

ditto.

> Source/WebKit/efl/ewk/ewk_tiled_backing_store_private.h:63
> +    Eina_Tiler *updates;    /**< updated/dirty areas */

ditto.

> Source/WebKit/efl/ewk/ewk_tiled_backing_store_private.h:77
> +    Evas_Object *image;           /**< Evas Image, the tile to be rendered */

ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.