[Webkit-unassigned] [Bug 84048] ShadowRoot needs resetStyleInheritance

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84048





--- Comment #22 from Dimitri Glazkov (Google) <dglazkov at chromium.org>  2012-05-14 20:06:54 PST ---
(From update of attachment 141840)
View in context: https://bugs.webkit.org/attachment.cgi?id=141840&action=review

> Source/WebCore/css/StyleResolver.cpp:1642
> +    bool resetStyleInheritance = element && element->treeScope()->resetStyleInheritance() && element->parentNodeForRenderingAndStyleAtShadowBoundary();

in this statement, the first two clauses are cheap, and the third one is expensive. What impact will this have on this hot function? Perhaps we could get rid of it somehow?

> Source/WebCore/dom/Node.h:510
> +    bool parentNodeForRenderingAndStyleAtShadowBoundary();

That is a crazy-long name. Do we really need to add this to Node?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.