[Webkit-unassigned] [Bug 82566] RenderTextControlSingleLine::scrollWidth/Height/Left/Top should not call back to DOM tree

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 14 15:51:49 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=82566





--- Comment #17 from Julien Chaffraix <jchaffraix at webkit.org>  2012-05-14 15:50:52 PST ---
(In reply to comment #16)
> I think the invariant we need to be testing for here is that we should not be triggering a layout by calling these getters.  We don't need to explicitly test for a crash, as that's just one of the things that can go wrong due to that underlying bug.

I can think of 2 ways to test:
* mutate the shadow DOM, mutate the <input> tag and then force a layout on the <input> (not sure it would crash but it's possible as we could recursively call layout in this case)
* expose a method to get the internal scroll dimensions using Internals, mutate the shadow DOM and compare the values before / after the mutation.

> I don't know how to check the timing of when a layout happens in a layout test, however.

The only direct way I can think of is through the web-inspector. The other methods would be indirect (timing difference in the operation in JavaScript as layout adds some overhead, ...).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list