[Webkit-unassigned] [Bug 86343] [EFL] New signals in ewk_view to enable global history delegate functionality

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=86343





--- Comment #2 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-05-14 03:39:07 PST ---
(From update of attachment 141677)
View in context: https://bugs.webkit.org/attachment.cgi?id=141677&action=review

> Source/WebKit/efl/ewk/ewk_view.h:306
> +    const char* url;  /**< url for the history */

Move '*' pointer to variable side.

> Source/WebKit/efl/ewk/ewk_view.h:307
> +    const char* title;  /**< title of the navigated page */

ditto.

> Source/WebKit/efl/ewk/ewk_view.h:310
> +    Eina_Bool hasSubstituteData;  /**< data substitution flag */

We are using efl coding style for public header files. So, clientRedirectSource need to be changed. For example, has_substitute_data.

> Source/WebKit/efl/ewk/ewk_view.h:311
> +    const char* clientRedirectSource;  /**< client redirect source url*/

ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.