[Webkit-unassigned] [Bug 84710] [EFL] [DRT] EventSender doesn't provide correct key string

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84710





--- Comment #18 from Kangil Han <kangil.han at samsung.com>  2012-05-14 02:08:04 PST ---
(In reply to comment #16)
> (From update of attachment 140851 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=140851&action=review
> 
> > Source/WebCore/ChangeLog:14
> > +        (WebCore::singleCharacterString):
> 
> Please mention what is being changed and why here.
> 
> > Tools/DumpRenderTree/efl/EventSender.cpp:481
> > +    if (keyName.isNull())
> > +        return new KeyEventInfo(character.get()->ustring().utf8(), modifiers, true);
> > +    if (keyName == "Return" || keyName == "Tab" || keyName == "BackSpace" || keyName == "space")
> > +        return new KeyEventInfo(keyName, modifiers, true);
> > +
> > +    return new KeyEventInfo(keyName, modifiers, false);
> 
> This change of logic here is very confusing, it took me a while to figure out what the code was supposed to do. The code should be more explicit in what it does.
> 
> My suggestion: add another CString member, `keyString' (or something better) to KeyEventInfo which is then passed as the 4th parameter to evas_event_feed_key_{down,up} so you don't need to put additional meaning into keyName itself. You can even make keyPadNameFromJSValue and keyNameFromJSValue return a KeyEventInfo themselves if that makes the code more simple.

Good suggestion rakuco! Thanks!
Please review my latest patch if I've got your idea. :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.