[Webkit-unassigned] [Bug 23750] Cannot resize frames because frameborder=0

Mon May 14 00:38:32 PDT 2012

https://bugs.webkit.org/show_bug.cgi?id=23750

--- Comment #12 from Eric Seidel <eric at webkit.org>  2012-05-14 00:37:36 PST ---
(From update of attachment 141332)
View in context: https://bugs.webkit.org/attachment.cgi?id=141332&action=review

Does this match other browsers?

> LayoutTests/fast/frames/frames-with-frameborder-zero-can-be-resized.html:1
> +<html>

Normally you would want an HTML5 doctype here.  <!DOCTYPE html>

> LayoutTests/fast/frames/frames-with-frameborder-zero-can-be-resized.html:43
> +                    document.getElementById("results").contentDocument.getElementById("console").appendChild(document.createTextNode((One.frameElement.width == 100 ? "PASS: "  : "FAIL: " ) + "frame'One' resized correctly\n"));
> +                    document.getElementById("results").contentDocument.getElementById("console").appendChild(document.createTextNode((Two.frameElement.height == 80 ? "PASS: "  : "FAIL: ") + "frame'Two' resized correctly"));

Don't you ahve a log function to do this?  I guess your log funciton isn't general purpose.

> LayoutTests/fast/frames/frames-with-frameborder-zero-can-be-resized.html:53
> +            <frame frameborder=0 name="One" style="border-right: 2px solid green;" />

self-closing tags are invalid html.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.