[Webkit-unassigned] [Bug 86306] DFG should be able to optimize foo.apply(bar, arguments)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=86306





--- Comment #12 from Filip Pizlo <fpizlo at apple.com>  2012-05-13 18:42:28 PST ---
(In reply to comment #10)
> (From update of attachment 141619 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=141619&action=review
> 
> > Source/JavaScriptCore/dfg/DFGCFGSimplificationPhase.cpp:72
> > +                        
> 
> You probably didn't mean to do this.
> 
> > Source/JavaScriptCore/dfg/DFGCapabilities.cpp:45
> > +    UNUSED_PARAM(result);
> 
> This is redundant (*shrug* :-) ).

Ooops!  Nope, it isn't.  The issue is that the only other use of it is the ASSERT.  So I have a choice between switching the ASSERT to ASSERT_UNUSED or keeping the UNUSED_PARAM.  I like keeping the UNUSED_PARAM better because the whole point of passing the result into this method is so that the verbose mode can use it to print things.  Hence, the UNUSED_PARAM on the #else case of the DEBUG_VERBOSE check, as opposed to an ASSERT_UNUSED that is unguarded by any other checks, is serving a useful purpose: if when building with DEBUG_VERBOSE mode the compiler finds that result is unused, then it should flag an error, which will hopefully serve as a signal to the hacker that he should remove the result argument altogether.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.