[Webkit-unassigned] [Bug 86306] DFG should be able to optimize foo.apply(bar, arguments)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=86306





--- Comment #5 from Filip Pizlo <fpizlo at apple.com>  2012-05-13 12:58:49 PST ---
(In reply to comment #4)
> (From update of attachment 141610 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=141610&action=review
> 
> > Source/JavaScriptCore/dfg/DFGCFGSimplificationPhase.cpp:556
> > +                if (false && node.variableAccessData()->isCaptured())
> > +                    break;
> > +                
> 
> false? this seems bogus :D
> 

Ooops!  I meant to kill that entire if statement rather than just turn it into a no-op.

> > Source/JavaScriptCore/dfg/DFGCapabilities.h:-198
> > -        return false;
> 
> What's this change?

That return was redundant.  If you look at the surrounding code, there's a return false below that this would fall-through to anyway.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.