[Webkit-unassigned] [Bug 86306] DFG should be able to optimize foo.apply(bar, arguments)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=86306


Filip Pizlo <fpizlo at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #141597|0                           |1
        is obsolete|                            |
 Attachment #141597|review?                     |
               Flag|                            |
 Attachment #141610|                            |review?
               Flag|                            |




--- Comment #3 from Filip Pizlo <fpizlo at apple.com>  2012-05-13 12:03:48 PST ---
Created an attachment (id=141610)
 --> (https://bugs.webkit.org/attachment.cgi?id=141610&action=review)
the patch

Made some refinements to the way that CFG simplification treats captured variables.  Previously I thought that it would be fine for CFG simplification to not do any fix-up to captured vars after merging basic blocks.  But now I think that it's cleaner if we preserve the invariant that even for captured vars, a GetLocal refers to the first prior access to the same variable, thereby ensuring that (1) we have a clean way of seeing the liveness of variables and (2) the unification-based variable splitting "just works".  Of course, the latter is only needed prior to CFG simplification, but I like the idea of CFG simplification producing a graph that is strictly more tidy than the one it received.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.