[Webkit-unassigned] [Bug 86060] WebKitDOMHTMLMediaElement.cpp - 'HTMLMediaElement' is not a member of 'WebCore'

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=86060


Noel <noel.vellemans at visionbms.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |noel.vellemans at visionbms.co
                   |                            |m




--- Comment #3 from Noel <noel.vellemans at visionbms.com>  2012-05-13 02:16:51 PST ---
(In reply to comment #2)
> Noel,
> 
> I will appreciate your help, if you could please manually patch the fix attached and confirm if that fixes your problem  ?


Hi Sriram,


I did your described patch manually, this leads for example to the following code that is generated automaticaly.

[ $conditionGuardStart   ...  $conditionGuardEnd into CodeGeneratorGObject.pm ]

Not working fine ...but it is going in the good direction.
Please have a look at my findings,

<< code snip begin >>
static void webkit_dom_html_media_element_set_property(GObject* object, guint prop_id, const GValue* value, GParamSpec* pspec)
{
    WebCore::JSMainThreadNullState state;
    #if ENABLE(VIDEO)    
    WebKitDOMHTMLMediaElement* self = WEBKIT_DOM_HTML_MEDIA_ELEMENT(object);
    WebCore::HTMLMediaElement* coreSelf = WebKit::core(self);
    #endif // ENABLE(VIDEO)

    switch (prop_id) {
    case PROP_SRC:
    {
        coreSelf->setAttribute(WebCore::HTMLNames::srcAttr, WTF::String::fromUTF8(g_value_get_string(value)));
        break;
    }
    case PROP_PRELOAD:
    {
        coreSelf->setPreload(WTF::String::fromUTF8(g_value_get_string(value)));
        break;
    }
 << code snip end >>

 If you have a look at this code you will see that it did change conditionaly some lines, but that it is not compilable.
 the case statment still uses the coreSelf-> which is not in there because it is in the  #if ENABLE(VIDEO) ...  #endif // ENABLE(VIDEO)

 Build log snip .

 DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp: In function 'void webkit_dom_html_media_element_set_property(GObject*, guint, const GValue*, GParamSpec*)':
DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp:156:9: error: 'coreSelf' was not declared in this scope
DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp:161:9: error: 'coreSelf' was not declared in this scope
DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp:167:9: error: 'coreSelf' was not declared in this scope
DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp:172:9: error: 'coreSelf' was not declared in this scope
DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp:177:9: error: 'coreSelf' was not declared in this scope
DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp:182:9: error: 'coreSelf' was not declared in this scope
DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp:187:9: error: 'coreSelf' was not declared in this scope
DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp:192:9: error: 'coreSelf' was not declared in this scope
DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp:198:9: error: 'coreSelf' was not declared in this scope
DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp:203:9: error: 'coreSelf' was not declared in this scope
DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp:208:9: error: 'coreSelf' was not declared in this scope
DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp:213:9: error: 'coreSelf' was not declared in this scope
DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp:218:9: error: 'coreSelf' was not declared in this scope
DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp:223:9: error: 'coreSelf' was not declared in this scope
DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp: In function 'void webkit_dom_html_media_element_get_property(GObject*, guint, GValue*, GParamSpec*)':
DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp:243:16: error: 'MediaError' is not a member of 'WebCore'
DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp:243:16: error: 'MediaError' is not a member of 'WebCore'
DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp:243:35: error: template argument 1 is invalid
DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp:243:41: error: invalid type in declaration before '=' token
DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp:243:43: error: 'coreSelf' was not declared in this scope
DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp:244:51: error: request for member 'get' in 'ptr', which is of non-class type 'int'
DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp:249:56: error: 'coreSelf' was not declared in this scope
DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp:254:56: error: 'coreSelf' was not declared in this scope
DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp:259:33: error: 'coreSelf' was not declared in this scope
DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp:264:56: error: 'coreSelf' was not declared in this scope
DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp:269:43: error: 'coreSelf' was not declared in this scope
DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp:270:56: error: no matching function for call to 'kit(WebCore::TimeRanges*)'
./Source/WebCore/bindings/gobject/WebKitDOMBinding.h:38:16: note: candidates are: WebKitDOMNode* WebKit::kit(WebCore::Node*)
./Source/WebCore/bindings/gobject/WebKitDOMBinding.h:39:19: note:                 WebKitDOMElement* WebKit::kit(WebCore::Element*)
./Source/WebCore/bindings/gobject/WebKitDOMBinding.h:40:17: note:                 WebKitDOMEvent* WebKit::kit(WebCore::Event*)
./Source/WebCore/bindings/gobject/WebKitDOMBinding.h:41:23: note:                 WebKitDOMEventTarget* WebKit::kit(WebCore::EventTarget*)
DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp:275:33: error: 'coreSelf' was not declared in this scope
DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp:280:36: error: 'coreSelf' was not declared in this scope
DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp:285:34: error: 'coreSelf' was not declared in this scope

Kind regards,
If I can do some more testing, please do not hesitate.

Noel

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.