[Webkit-unassigned] [Bug 86129] [BlackBerry] Enable the Fullscreen API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=86129





--- Comment #15 from Antonio Gomes <tonikitoo at webkit.org>  2012-05-12 19:39:51 PST ---
(In reply to comment #14)
> (In reply to comment #13)
> > > This is just a null pointer check to avoid a seg fault upon Browser shutdown. I don't think most null pointer checks need a Layout test.
> > 
> > That is an invalid assumption.
> 
> Can you give more details, Antonio? There are many thousands of null pointer checks in WebKit code. For example, lines like this are extremely common:
> 
> if (!page() || !page()->settings()->fullScreenEnabled())
>     break;
> 
> Often there are multiple tests per line. Null checks can be considered a good, preventive coding practice. Are you saying that each individual null check needs its own layout test?

Many existing null-checks came with layout tests, that is what I am saying. If you are fixing a crash with a null check, you can in many cases test it.

Shutdown is a particular situation where null-checks can be more easily accepted without a test.

Otherwise, the author has to say why it is not possible to come up with a test.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.