[Webkit-unassigned] [Bug 86235] [BlackBerry] Allow the platform media player to determine the media element's paused/playing status

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=86235





--- Comment #12 from Eric Carlson <eric.carlson at apple.com>  2012-05-12 13:51:22 PST ---
(From update of attachment 141575)
View in context: https://bugs.webkit.org/attachment.cgi?id=141575&action=review

> LayoutTests/media/media-continues-playing-after-replace-source.html:14
> +        function swapAudio() {

A function's opening brace should be on a new line.

> LayoutTests/media/media-continues-playing-after-replace-source.html:25
> +             logResult(false, "Caught 'error' event, audio.error.code = " + this.error.code);
> +             endTest();

This could be simplified to: failTest("Caught 'error' event, audio.error.code = " + this.error.code);

> LayoutTests/media/media-continues-playing-after-replace-source.html:45
> +            if (timeupdateEventCount-skippedCount == 1) {

There should be spaces around the minus sign.

> LayoutTests/media/media-continues-playing-after-replace-source.html:46
> +                // First time update after source replacement should be 0.

I am not sure I understand this comment. Do you mean that currentTime should be 0 when the first timeUpdate event fires? It would be good to clarify the comment when this test is updated.

> LayoutTests/media/media-continues-playing-after-replace-source.html:60
> +            } else if (timeupdateEventCount-skippedCount >= 2) {

Ditto.

> LayoutTests/media/media-continues-playing-after-replace-source.html:74
> +                    // The ports are not consistent in regards to whether
> +                    // the canplaythrough and playing events are triggered
> +                    // a second time, so stop listening for them. This was
> +                    // done to help the cr-linux test pass, and does not
> +                    // necessarily indicate a problem.

The ports should *definitely* be consistent here. Please file a bug so we can figure out what the correct behavior is and fix it.

> LayoutTests/media/media-continues-playing-after-replace-source.html:91
> +            //audioElement.removeChild(audioElement.childNodes[0]);

The commented out code should be removed.

> LayoutTests/media/media-continues-playing-after-replace-source.html:103
> +        document.write("<audio controls></audio>");

Is creating the audio element with document.write necessary for the test?

> LayoutTests/media/media-continues-playing-after-replace-source.html:104
> +        testAudioElement(0);

It doesn't look like the index passed to testAudioElement is necessary any more (eg. swapAudio is hard coded to use 0).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.