[Webkit-unassigned] [Bug 83254] [EFL] Support for Battery Status API on the WebKit-Efl

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=83254





--- Comment #59 from Kihong Kwon <kihong.kwon at samsung.com>  2012-05-12 09:57:09 PST ---
(In reply to comment #58)
> (In reply to comment #57)
> > (In reply to comment #56)
> > > From the log of ews, the configuration wasn't complete. Does this patch introduce some new dependencies?
> > 
> > Yes, this patch makes a new dependency to edbus.
> 
> Good, we can fix ews later.
> > 
> > > In addition, do you think this patch will fix some existing layout tests or maybe new tests are needed?
> > 
> > I haven't thought there are needed more test cases for this patch, if this patch passes "LayoutTests/batterystatus".
> > Do you think we need to add other specific test case for this patch?
> 
> Great, that's exactly what I mean. If the patch improves the pass rate for LayoutTests/batterystatus, we should see some changes in either Skipped file or perhaps efl test expectations. No need to work on new tests if we show previously failed tests are passing now.

There are no previously failed test cases.
I think my answer is not good enough to explain. I am sorry for that.
When I wrote Battery Status API for WebCore, I didn't implement actual working parts for the efl port.
This patch is continuous implementation of Battery Status API for the efl port.
But, I thought it is OK if this patch doesn't have problems with test cases which are already passed.
How do you think about this? Do we need another tests for this?
Thank you for your review. Chang Shu.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.