[Webkit-unassigned] [Bug 86129] [BlackBerry] Enable the Fullscreen API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=86129





--- Comment #14 from Max Feil <mfeil at rim.com>  2012-05-12 08:45:46 PST ---
(In reply to comment #13)
> > This is just a null pointer check to avoid a seg fault upon Browser shutdown. I don't think most null pointer checks need a Layout test.
> 
> That is an invalid assumption.

Can you give more details, Antonio? There are many thousands of null pointer checks in WebKit code. For example, lines like this are extremely common:

if (!page() || !page()->settings()->fullScreenEnabled())
    break;

Often there are multiple tests per line. Null checks can be considered a good, preventive coding practice. Are you saying that each individual null check needs its own layout test?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.