[Webkit-unassigned] [Bug 67935] webkit-patch should add reviewer if "Reviewed by NOBODY (OOPS!)." is missing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67935


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #141425|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #3 from Adam Barth <abarth at webkit.org>  2012-05-11 09:57:26 PST ---
(From update of attachment 141425)
View in context: https://bugs.webkit.org/attachment.cgi?id=141425&action=review

Changes to webkitpy require unit tests.  Both changelog.py and updatechangelogswithreviewer.py have unit tests that should be easy to extend to test this change.

> Tools/Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:75
> +                if not self._tool.user.confirm("Do you want to continue?", default="n"):

Do we need to check the --non-interactive option before prompting the user?

> Tools/Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:76
> +                        self._exit(1)

Is this the proper way to exist, or should we call error() ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.