[Webkit-unassigned] [Bug 67935] webkit-patch should add reviewer if "Reviewed by NOBODY (OOPS!)." is missing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67935





--- Comment #2 from Rafael Brandao <rafael.lobo at openbossa.org>  2012-05-11 09:09:47 PST ---
(From update of attachment 141425)
View in context: https://bugs.webkit.org/attachment.cgi?id=141425&action=review

Just an informal review.

> Tools/Scripts/webkitpy/common/checkout/changelog.py:345
> +        founded_reviewer = re.search(".*NOBODY\s*\(OOPS!\).*", latest_entry, re.MULTILINE)

English typo, it should be "found" not "founded".
Also, you look for the pattern "NOBODY (OOPS!)" and if you find it, you add the reviewer name. How is this going to fix what has been proposed on bug title?

> Tools/Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:72
> +            has_been_set = ChangeLog(changelog_path).set_reviewer(reviewer)

Name is weird. What has been set? Also, it doesn't look natural that a function called "set_reviewer" also returns something.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.