[Webkit-unassigned] [Bug 85711] Web Inspector: Turn HelpScreen to be View.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri May 11 07:33:51 PDT 2012
https://bugs.webkit.org/show_bug.cgi?id=85711
--- Comment #11 from eustas.bug at gmail.com 2012-05-11 07:32:55 PST ---
(From update of attachment 141395)
View in context: https://bugs.webkit.org/attachment.cgi?id=141395&action=review
>> Source/WebCore/ChangeLog:6
>> + Motivation: for further UI changes, HelpSceen need to be View.
>
> s/need/needs. Also, you may want to mention the intended future changes (e.g. make it a tabbed view).
Fixed.
>> Source/WebCore/inspector/front-end/SettingsScreen.js:607
>> + this._statusBarButton = button;
>
> Can we make this simpler by not using the intermediate local variable?
We can. But doesn't local variable here make code more readable?
Fixed.
>> Source/WebCore/inspector/front-end/SettingsScreen.js:610
>> + this._settingsScreen;
>
> What's that for?
That is member type declaration.
>> Source/WebCore/inspector/front-end/SettingsScreen.js:634
>> + showSettingsScreen: function()
>
> does this have to be public?
This method is planned to be used outside of controller (with optional parameter "tabToShowId").
Fixed for now.
>> Source/WebCore/inspector/front-end/SettingsScreen.js:643
>> + hideSettingsScreen: function()
>
> ditto
Fixed.
>> Source/WebCore/inspector/front-end/ShortcutsScreen.js:56
>> this._buildTable(this.contentElement);
>
> Does it really make a difference whether we render this before, not after this is shown? I.e., are there strong reasons we can't live with wasShown()?
There are no strong reasons. Reverted.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list