[Webkit-unassigned] [Bug 86195] [EFL][DRT] LayoutTestController does not implement clearApplicationCacheForOrigin

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=86195





--- Comment #2 from Raphael Kubo da Costa (rakuco) <rakuco at webkit.org>  2012-05-11 06:58:34 PST ---
(From update of attachment 141388)
View in context: https://bugs.webkit.org/attachment.cgi?id=141388&action=review

I wonder if we should use the word "origin" for the ewk_settings function -- I would expect it to take a Ewk_Security_Origin, not a const char*.

> Source/WebKit/efl/ewk/ewk_settings.h:256
> + * Removes the HTML5 application cache for a security origin.

Nit: "remove" may be too strong a verb here; "clear" sounds better.

> Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp:553
> +void LayoutTestController::clearApplicationCacheForOrigin(OpaqueJSString *origin)

Nit: wrong placement of the asterisk.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.