[Webkit-unassigned] [Bug 86055] [BlackBerry] [DRT] Ref-tests were not run by torch-launcher

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=86055


Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #141333|review?                     |review+
               Flag|                            |




--- Comment #10 from Rob Buis <rwlbuis at gmail.com>  2012-05-11 04:32:12 PST ---
(From update of attachment 141333)
View in context: https://bugs.webkit.org/attachment.cgi?id=141333&action=review

Looks much better! Please fix remaining issues before landing.

> ChangeLog:8
> +        Ref-tests are tests with surfix "-expected", "-expected-mismatch" and a valid

surfix!

> Tools/DumpRenderTree/blackberry/DumpRenderTree.cpp:209
> +    const char* extensions[] = {".html"};

We may want to add .svg as possible ref-test extension later.

> Tools/DumpRenderTree/blackberry/DumpRenderTree.cpp:222
> +

Remove empty line.

> Tools/DumpRenderTree/blackberry/DumpRenderTree.cpp:401
> +    // and multiple mismatch ref-tests

Lacks a period at the end.

> Tools/DumpRenderTree/blackberry/DumpRenderTree.cpp:403
> +        getRefTests(*iter);

I think it should be getRefTest, not getRefTests.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.