[Webkit-unassigned] [Bug 84572] [EFL] Split ewk_private.h file to multiple private files.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84572





--- Comment #4 from Thiago Marcos P. Santos <tmpsantos at gmail.com>  2012-05-11 03:56:04 PST ---
(From update of attachment 141347)
View in context: https://bugs.webkit.org/attachment.cgi?id=141347&action=review

General comments:

When generating the docs, I'm getting documentation for a lot of private headers. I think the idea of private headers is exactly the opposite: hide from the users so we don't make any commitment on these APIs.

I just realized that we are not enabling any kind of warning since security origin in not including the private header and I don't get any message. 

I tried a build here disabling all the possible things that we support disabling and it just worked. :)

Thanks for the patch.

> Source/WebKit/efl/ewk/ewk_auth_soup_private.h:61
> + */

Docs of private things should be moved to .cpp files and marked as @internal

> Source/WebKit/efl/ewk/ewk_logging_private.h:1
> +/*

I think the logging macros can stay on the "global" ewk_private.h

> Source/WebKit/efl/ewk/ewk_private.h:28
>  

The docs of this file needs to be updated. It says "Private methods of WebKit-EFL." and now has only some declarations.

> Source/WebKit/efl/ewk/ewk_security_origin_private.h:29
> +// forward declarations

Nitpicking but I don't thing this kind of comments are necessary.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.