[Webkit-unassigned] [Bug 86175] HasCustomWillOrDidRecalcStyleFlag and family should live in a bit.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 11 03:04:20 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=86175





--- Comment #1 from Ryosuke Niwa <rniwa at webkit.org>  2012-05-11 03:03:24 PST ---
(In reply to comment #0)
> Following flags are used to indicate that the node has some special callback functions.
> 
> - HasCustomWillOrDidRecalcStyleFlag
> - HasCustomStyleForRendererFlag
> - IsFrameOwnerElementFlag
> 
> We can replace them with a flag namely, say, HasCustomCallbacks.
> And have optional virtual method to check which types of callbacks the node actually has.
> Since majority of node doesn't have none of them and even single bit can work for early-out check.

Why do we need those extra bits? Also adding virtual function calls don't seem like a good idea. Do we have any data on how rare these flags are?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list