[Webkit-unassigned] [Bug 85991] REGRESSION (r116331): RSS Headlines/links are missing (-webkit-box-flex broken?)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=85991





--- Comment #21 from Ojan Vafai <ojan at chromium.org>  2012-05-11 00:00:29 PST ---
(In reply to comment #20)
> (In reply to comment #14)
> > Created an attachment (id=141289)
 --> (https://bugs.webkit.org/attachment.cgi?id=141289&action=review) [details] [details]
> > Patch
> 
> > if (!isTableCell() && styleToUse->logicalWidth().isFixed() 
>   && styleToUse->logicalWidth().value() >= 0 && style()->marqueeBehavior() !=      MALTERNATE && !isDeprecatedFlexItem())
> 
> Hey Tony you need to add a check for width:0 also in the deprecated flex box case. 
> Behavior before r116331
> When the width > 0 then the width is taken
> otherwise calculated width of the content is taken.
> 
> So !isDeprecatedFlexItem() will become 
> !(isDeprecatedFlexItem() && styleToUse->logicalWidth().value()==0) shuld restore the behavior in case of flex box prior to r116331.

Yup. That's more correct. Pravin, if you have the time, you could upload a patch with this fix and with an appropriate layout test.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.