[Webkit-unassigned] [Bug 86055] [BlackBerry] [DRT] Ref-tests were not run by torch-launcher

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=86055


Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #141094|review?                     |review-
               Flag|                            |




--- Comment #4 from Rob Buis <rwlbuis at gmail.com>  2012-05-10 14:39:47 PST ---
(From update of attachment 141094)
View in context: https://bugs.webkit.org/attachment.cgi?id=141094&action=review

Looks good, can be cleaned up some more.

> ChangeLog:1
> +2012-05-09  Xiaobo Wang  <xbwang at torchmobile.com.cn>

You need an empty line here.

> Tools/DumpRenderTree/blackberry/DumpRenderTree.cpp:206
> +    const char* surfixes[] = {"-expected", "-expected-mismatch"};

Typo, suffix.

> Tools/DumpRenderTree/blackberry/DumpRenderTree.cpp:207
> +    const int countofSurfixes = sizeof(surfixes) / sizeof(const char*);

Ditto.

> Tools/DumpRenderTree/blackberry/DumpRenderTree.cpp:406
> +    for (Vector<WTF::String>::iterator iter = files.begin(); files.end() != iter; ++iter)

Can you try if it works if you do not add WTF:: in this cpp file?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.