[Webkit-unassigned] [Bug 85880] [SOUP] Allow sending URI request data in chunks

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=85880





--- Comment #11 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-05-10 03:54:39 PST ---
(In reply to comment #10)
> (In reply to comment #8)
> > (From update of attachment 140735 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=140735&action=review
> > 
> > > Source/WebKit2/WebProcess/soup/WebSoupRequestManager.h:58
> > > +    void handleURIRequest(const CoreIPC::DataReference&, uint64_t contentLength, const String& mimeType, uint64_t requestID);
> > > +    void addDataToURIRequest(const CoreIPC::DataReference&, uint64_t requestID);
> > 
> > Another quick comment here... Perhaps these names should be similar to the names that WebCore uses in these situations, like handleURISchemeResponseReceived and handleURISchemeResponseData or something even better.
> 
> Yes, I don't like the names either, but I couldn't think of a better name.

The names are indeed confusing, the request is handled by the UI process, so sending a message to the web process called HandleFoo makes me think the web process is supposeed to handle it. So, I think DidHandleURIRequest and DidReceiveURIREquestData make more sense.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.