[Webkit-unassigned] [Bug 79150] [chromium] Add Link Preview behavior to WebViewImpl

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=79150


Tien-Ren Chen <trchen at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |trchen at chromium.org




--- Comment #12 from Tien-Ren Chen <trchen at chromium.org>  2012-05-09 15:52:45 PST ---
(In reply to comment #9)
> I no longer work on this.  I'll ask the new owner to follow up on it.

Hi all, I'll be responsible for upstreaming our link preview code.

(In reply to comment #8)
> Michael, do you have thoughts on fishd's comments above?  I tend to agree with fishd that 230 line functions are too large to be maintainable.  The path forward here is likely to discuss how best to factor this code into something more maintainable.

Totally agree. Our WebViewImpl::getTouchHighlightQuads function is multiplexed with too many functionality at this time, including
* hit test & touch targets disambiguation
* find out the highlight quads (when only 1 touch target is available)
* find out a reasonable rect for link preview (when 2 or more touch targets are available)

Currently I'm working on the first and second part, cooperating with CrOS people who also want link highlighting.

For the hit test & disambiguation code I'm still trying to understand it and refactor it. In the meantime the CrOS people will reuse EventHandler.cpp::findBestClickableCandidate.

The highlight quads code has been rewritten to support threaded scrolling/animation, currently waiting for review:
https://bugs.webkit.org/show_bug.cgi?id=84936 --- depends on --> https://bugs.webkit.org/show_bug.cgi?id=85725

As for link preview, I'm not certain what is the current plan on this. As far as I know we're going to allow panning in the preview area, and move much of the functionality into the compositor. Need to discuss that after getting the highlight to work first.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.