[Webkit-unassigned] [Bug 84414] Expose a flag so that fullscreen video on android can work with FULLSCREEN_API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84414





--- Comment #25 from Min Qin <qinmin at chromium.org>  2012-05-09 13:25:54 PST ---
(In reply to comment #22)
> (From update of attachment 139467 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=139467&action=review
> 
> > Source/WebCore/platform/graphics/MediaPlayer.h:330
> > +    bool enterFullscreen() const;
> 
> Why would you change this to be const?? That is not a method free of side effects on the state of the media player.

So this is what could happen for chrome on android, when calling enterFullscreen() it could actually fail for the following 2 reasons:
1. if the MediaPlayerPrivate object is gone.
2. the native media player is already in fullscreen mode.

Since this return value is not used when ENABLE(PLUGIN_PROXY_FOR_VIDEO) is set, returning true should just be fine.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.