[Webkit-unassigned] [Bug 84312] [Chromium] Added more params to Chromium-Webkit print api to implement auto fit to page functionality.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed May 9 11:53:42 PDT 2012
https://bugs.webkit.org/show_bug.cgi?id=84312
Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #139405|review? |review-
Flag| |
--- Comment #12 from Darin Fisher (:fishd, Google) <fishd at chromium.org> 2012-05-09 11:52:46 PST ---
(From update of attachment 139405)
View in context: https://bugs.webkit.org/attachment.cgi?id=139405&action=review
> Source/WebKit/chromium/public/WebFrame.h:468
> + // TODO(kmadhusu at chromium.org): This is a temporary interface to avoid the
nit: webkit style doesn't use TODO(user). just use FIXME.
> Source/WebKit/chromium/public/WebFrame.h:488
> + virtual int printBegin(const WebSize& printContentSize,
I suspect it would be better to bottle up these parameters into a WebPrintParams
struct. See for example WebPluginParams. Exclude the constrainToNode parameter
so that you can reuse WebPrintParams in the WebPlugin printBegin method.
> Source/WebKit/chromium/public/WebPlugin.h:104
> + // TODO(kmadhusu at chromium.org): Change the data type of printScalingOption to
nit: TODO(user) -> FIXME
Use WebPrintParams here too.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list