[Webkit-unassigned] [Bug 85425] Use suitable viewport values when a Mobile DTD is used.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=85425





--- Comment #56 from Zalan Bujtas <zbujtas at gmail.com>  2012-05-09 11:26:23 PST ---
(From update of attachment 140971)
View in context: https://bugs.webkit.org/attachment.cgi?id=140971&action=review

> Source/WebCore/dom/Document.cpp:777
> +        if (!ownerElement()

Aren't this and the mainframe() check at updateViewportArguments() supposed to serve the same purpose? (that we only do meta viewport for mainframes) While they are probably in sync functionality wise at this point(!ownerelement() vs. page()->mainFrame() == frame()), it is somewhat error prone setup and can result in a situation, where the m_viewportArguments value is changed, but it's not dispatched further and the actual viewport ends being up out of sync. Wondering why you switched from using the slightly slower, but less error prone way of passing the viewport attributes? processViewport("width=device-width, initial-scale=1");

> Source/WebCore/dom/Document.cpp:778
> +            && m_docType->publicId().startsWith("-//wapforum//dtd xhtml mobile 1.", /* caseSensitive */ false)) {

Missing your proposal of putting ASSERT here. I think it would be great to have ASSERT(m_viewportArgument.type == Implicit), now that check is removed.

> Source/WebCore/dom/ViewportArguments.h:61
> +        XHTMLMobileProfile,

is it still needed?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.