[Webkit-unassigned] [Bug 85998] [GTK] Add webkit_web_view_can_show_mime_type() to WebKit2 GTK+ API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=85998





--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-05-09 09:24:24 PST ---
(In reply to comment #3)
> (From update of attachment 140955 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=140955&action=review
> 
> > Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:202
> > +    if (decisionType != WEBKIT_POLICY_DECISION_TYPE_RESPONSE) {
> > +        webkit_policy_decision_use(decision);
> > +        return TRUE;
> > +    }
> > +
> > +    WebKitURIResponse* response = webkit_response_policy_decision_get_response(WEBKIT_RESPONSE_POLICY_DECISION(decision));
> > +    if (webkit_web_view_can_show_mime_type(webView, webkit_uri_response_get_mime_type(response)))
> > +        webkit_policy_decision_use(decision);
> > +    else
> > +        webkit_policy_decision_download(decision);
> > +
> 
> Hrm. It seems odd that a library would write non-cache data to the filesystem without the embedder specifically opting in to that.

This is what wk1 does, try to open a binary file in minibrowser, for example, and the data is loaded inot the view as text. That's no expected. Note that download() doesn't download the file, but initiates a download operation. That's how all browsers work when you click on link and the content can't be shown in the web view.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.