[Webkit-unassigned] [Bug 85907] [BlackBerry] Enable PAGE_POPUP in make file, and implement required methods

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=85907


Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #140947|review?                     |review-
               Flag|                            |




--- Comment #8 from Rob Buis <rwlbuis at gmail.com>  2012-05-09 08:32:18 PST ---
(From update of attachment 140947)
View in context: https://bugs.webkit.org/attachment.cgi?id=140947&action=review

Looks good, can be improved some more.

> Source/WebKit/blackberry/Api/WebPage.cpp:378
> +

You don't need the empty line.

> Source/WebKit/blackberry/Api/WebPage.cpp:6106
> +    return (d->m_selectPopup) ? false : true;

It does not need to be this explicit, just say return d->m_selectPopup;

> Source/WebKit/blackberry/Api/WebPage.h:341
> +    WebCore::PagePopupBlackBerry* popup();

Can some be const, like hasOpenedPopup?

> Source/WebKit/blackberry/Api/WebPage_p.h:544
> +

No need for empty line.

> Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp:314
> +    }

You can move the webPopup->sendCreatePopupWebViewRequest(); usage to here so you state it once.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.