[Webkit-unassigned] [Bug 85194] [GTK] Missing WebPreferences for media playback requiring user gestures and inline playback

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=85194





--- Comment #7 from Simon Pena <spena at igalia.com>  2012-05-09 07:55:04 PST ---
(In reply to comment #6)
> (From update of attachment 139466 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=139466&action=review
> 
> Looks good. r- only because you don't have commit access yet the documentation isn't quite clear.
> 
> > Source/WebKit/gtk/webkit/webkitwebsettings.cpp:985
> > +    * Whether an user gesture would be required to start media playback or load
> > +    * media. This is off by default, so media playback could start
> > +    * automatically. Setting it on requires a gesture by the user to start
> > +    * playback, or to load the media.
> > +    *
> 
> Weird English rules exception nit: Whether an user -> Whether a user 

Thanks for catching, I'll fix this.

> I think this documentation could be slightly more clear about what kind of gesture is required to start playback. For instance, if I turn this on, what will I need to do to trigger playback? Mouse over the page? Mouse over the element itself? Click on the element?

>From « LayoutTests/media/video-play-require-user-gesture.html », I understand it typically involves clicking on the Play button, but probably other gestures could be required.

I guess I can make the documentation read something like:

« Whether a user gesture (typically clicking on the play button) would be required to start media playback or load media... »

What do you think? I'll use the same description for the WK2 patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.