[Webkit-unassigned] [Bug 85425] Use suitable viewport values when a Mobile DTD is used.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=85425





--- Comment #51 from Zalan Bujtas <zbujtas at gmail.com>  2012-05-09 07:14:02 PST ---
(In reply to comment #49)
> (In reply to comment #48)
> > (From update of attachment 140817 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=140817&action=review
> > 
> > > Source/WebCore/dom/Document.cpp:777
> > > +        if (m_viewportArguments.type < ViewportArguments::XHTMLMobileProfile
> > 
> > Looking at the html5 spec, I don't think <meta> can be followed by the doctype declaration, so not sure how can the current viewportargument type be greater than Implicit. Did I miss something here?
> 
> There are many sites[1] that use the XHTML-MP doc type but also the viewport meta tag, so the non-legacy way of set the viewport takes precedence over the legacy ways.
> 
> [1] e.g.: http://m.cnn.com, http://m.facebook.com
Yes and that's indeed the right priority order.
What I meant was this: http://trac.webkit.org/browser/trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp#L518

DocType doesn't get inserted, unless the HTMLBuilder is in InitialMode, which does not look to be possible if <meta> is reached already.
It's just nitpicking, if no one has objection, I don't mind having the check like that.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.