[Webkit-unassigned] [Bug 85921] [chromium] Only increase size of Combo Box Options when displayed on touch screen

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=85921





--- Comment #10 from Robert Flack <flackr at chromium.org>  2012-05-09 06:54:02 PST ---
(From update of attachment 140806)
View in context: https://bugs.webkit.org/attachment.cgi?id=140806&action=review

>> Source/WebCore/page/Settings.h:736
>> +        bool m_deviceTouchScreen : 1;
> 
> it doesn't make any sense for this to be a bitfield here - it'll pack out to a full word anyway.  move it up a bit if you want to be in the bitfield above.
> 
> does it make sense for this to exist when ENABLE(TOUCH_EVENTS) is not set?

Moved up to be part of the bitfield.

I think conceptually this is orthogonal to whether touch events are enabled. Developers may want to set this flag to test how their site will lay out on a touch screen (especially if/when we have a media query for this), and users can use a touch screen to drive mouse events even if touch events are not enabled and some browsers may want to set this. That being said I'm not strongly opposed to putting this behind ENABLE(TOUCH_EVENTS).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.