[Webkit-unassigned] [Bug 84048] ShadowRoot needs resetStyleInheritance

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84048


Hajime Morrita <morrita at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #139609|review?                     |review-
               Flag|                            |




--- Comment #20 from Hajime Morrita <morrita at google.com>  2012-05-09 04:53:31 PST ---
(From update of attachment 139609)
View in context: https://bugs.webkit.org/attachment.cgi?id=139609&action=review

> Source/WebCore/css/StyleResolver.cpp:1604
> +    bool crossShadowBoundary = element && m_parentNode && element->treeScope() != m_parentNode->treeScope();

I noticed that we don't need to compare tree scopes to detect the boundary.
We compute m_parentNode using Node::parentNodeForRenderingAndStyle(), which is implemented using NodeRenderingContext.
And NodeRenderingContext should know what we need to know.
I think we can use it directly instead of calling parentNodeForRenderingAndStyle().
Or we can add an extra out-parameter to pass necessary information.
Then we don't need to re-query tree scope of each node.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.