[Webkit-unassigned] [Bug 85945] DFG variable capture analysis should work even if the variables arose through inlining

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=85945





--- Comment #2 from Oliver Hunt <oliver at apple.com>  2012-05-08 22:14:49 PST ---
(From update of attachment 140849)
View in context: https://bugs.webkit.org/attachment.cgi?id=140849&action=review

In general this patch looks fine (aside from the bool vs. enum issue i mention), but i'm somewhat tired so don't feel sufficiently focussed to r+ it.  Will re-review in the morning.

> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:114
> -    VariableAccessData* newVariableAccessData(int operand)
> +    VariableAccessData* newVariableAccessData(int operand, bool isCaptured)

We try to use enums rather than bools in cases like this as they're more descriptive, and you also escape the automatic int->bool conversion purgatory

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.