[Webkit-unassigned] [Bug 85063] Add low memory check in ExecutableAllocator::underMemoryPressure()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=85063





--- Comment #29 from George Staikos <staikos at kde.org>  2012-05-08 16:22:46 PST ---
(In reply to comment #28)
> (In reply to comment #27)
> > (In reply to comment #24)
> > > (From update of attachment 139452 [details] [details] [details])
> > > View in context: https://bugs.webkit.org/attachment.cgi?id=139452&action=review
> > > 
> > > > Source/JavaScriptCore/ChangeLog:9
> > > > +        Call WTF::isSystemMemoryLow() to check whether system memory is low in
> > > > +        ExecutableAllocator::underMemoryPressure(). This will force collecting
> > > > +        of garbage, thus avoiding out of system memory while at the same time
> > > > +        we have a lot of unused memory waiting to be released.
> > > 
> > > I'm not sure I buy this.  ExecutableAllocator has _nothing_ to do with garbage collection.  It only deals with JIT memory.  This method returning true should only cause us to jettison JIT memory; it will not cause any other kinds of memory reclamation.
> > 
> > Can't this be considered useful?  Seems to me it is.
> 
> That's besides the point.  The change log comment is wrong.

Ok, it wasn't clear to any of the three of us that this was your point.  

Lyon, you should fix that.

Any other concerns with it Filip?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.