[Webkit-unassigned] [Bug 83486] [EFL][DRT] EventSender needs implementation of leapForward function

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=83486


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #140689|review?, commit-queue?      |review+, commit-queue+
               Flag|                            |




--- Comment #18 from Eric Seidel <eric at webkit.org>  2012-05-08 16:11:36 PST ---
(From update of attachment 140689)
View in context: https://bugs.webkit.org/attachment.cgi?id=140689&action=review

Seems reasonable.  rs=me.

> Tools/DumpRenderTree/efl/EventSender.cpp:122
> +struct MouseEventInfo {

Structs tend to very quickly become classes. :)

> Tools/DumpRenderTree/efl/EventSender.cpp:302
> +    MouseEventInfo* eventInfo = new MouseEventInfo(EvasMouseEventMove);

OwnPtr?

> Tools/DumpRenderTree/efl/EventSender.cpp:700
> +    delete eventInfo;

:(  Manual memory management is sad times. :(

> Tools/DumpRenderTree/efl/EventSender.cpp:709
> +            usleep(delayedEvent.delay * 1000);

This is sad.  That we need to artificially slow down the testing?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.