[Webkit-unassigned] [Bug 85670] [BlackBerry] Implement a popup client for HTML controls

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=85670





--- Comment #13 from Yong Li <yong.li.webkit at gmail.com>  2012-05-08 14:22:38 PST ---
(From update of attachment 140781)
View in context: https://bugs.webkit.org/attachment.cgi?id=140781&action=review

Other than the "strArgs" issue, the patch looks good to me

> Source/WebKit/blackberry/WebCoreSupport/PagePopupBlackBerry.cpp:143
> +    WTF::Vector<char> strArgs;
> +    JSStringGetUTF8CString(string, strArgs.data(), sizeUTF8);

We have to allocate enough buffer for strArgs. Otherwise strArgs.data() is a null pointer. The reason I suggested to use Vector<char> is I hate "delete". OwnArrayPtr<char> should also work.

> Source/WebKit/blackberry/WebCoreSupport/PagePopupBlackBerry.cpp:152
> +    client->setValueAndClosePopup(0, strArgs.data());

Are we sure the string data has a null terminator included? Otherwise, we have to pass the string length.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.