[Webkit-unassigned] [Bug 85725] Eliminate duplicated code for culled line box in RenderInline

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 8 14:05:30 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=85725





--- Comment #2 from Tien-Ren Chen <trchen at chromium.org>  2012-05-08 14:04:34 PST ---
Can someone take a look at this please?

I think it is a good refactor to have one single function to generate all the local rects of a RenderInline.

There is one concern with this patch is the use of template and generator pattern, neither of them is used in WebKit. I use such seemingly over-complicated construct to make sure the compiled code will be as efficient as it was. If performance is not that much a concern I can make a simpler implementation that returns just a Vector<FloatRect>.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list