[Webkit-unassigned] [Bug 82838] [EFL] EFL's LayoutTestController keepWebHistory implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=82838





--- Comment #7 from Raphael Kubo da Costa (rakuco) <rakuco at webkit.org>  2012-05-08 13:26:54 PST ---
(From update of attachment 140184)
View in context: https://bugs.webkit.org/attachment.cgi?id=140184&action=review

The API does not look very good to me yet:

 - "optional_shared_history" is too clunky. I still don't know if it makes sense to make the shared history an Ewk_History at all, or go the Qt route and have a separate object for that.
 - There seems to be no way to destroy the shared history object correctly (it's not done in DRT, and Qt uses qAddPostRoutine for that).

> Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp:961
> +    // FIXME: primitive behaviour yet for enabling Layout tests. See mac or win ports implementation.

Can you elaborate on what these ports do differently from us?

> Source/WebKit/efl/ewk/ewk_history.cpp:215
> +int ewk_history_all_item_count(const Ewk_History *history)
> +{
> +    EWK_HISTORY_CORE_GET_OR_RETURN(history, core, 0);
> +    return static_cast<int>(core->entries().size());
> +}

I wonder if there's really a need for this method -- it's the same as back_list_length + forward_list_length.

> Tools/ChangeLog:9
> +        LayoutTestController::keepWebHistory() implementation added.
> +        LayoutTestController::webHistoryItemCount() returns count of all history items including the current one. 

These can be moved to the method list below.

> Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp:112
> +    if (!ewk_history_optional_shared_history_get())
> +        ewk_history_optional_shared_history_set(ewk_history_new());

Don't you need to reset this after each test?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.