[Webkit-unassigned] [Bug 85670] [BlackBerry] Implement a popup client for HTML controls

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=85670


Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #140758|review?                     |review-
               Flag|                            |




--- Comment #10 from Rob Buis <rwlbuis at gmail.com>  2012-05-08 12:12:12 PST ---
(From update of attachment 140758)
View in context: https://bugs.webkit.org/attachment.cgi?id=140758&action=review

Looks good, can be cleaned up a bit more.

> Source/WebKit/blackberry/WebCoreSupport/PagePopupBlackBerry.cpp:212
> +    JSC::UString name("popUp");

Yong can review this better than me. I do wonder if popUp is a good name.

> Source/WebKit/blackberry/WebCoreSupport/PagePopupBlackBerry.cpp:233
> +                event);

Combine the two lines above into one line.

> Source/WebKit/blackberry/WebCoreSupport/PagePopupBlackBerry.cpp:258
> +}

I think early return is preferred here:

if (!m_page) {
    m_page->clear();
    return;
}
m_page->
....

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.