[Webkit-unassigned] [Bug 85576] [BlackBerry] AutofillManager implementation upstream

Mon May 7 18:59:57 PDT 2012

https://bugs.webkit.org/show_bug.cgi?id=85576

Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #140642|review?                     |review-
               Flag|                            |

--- Comment #8 from Rob Buis <rwlbuis at gmail.com>  2012-05-07 18:59:56 PST ---
(From update of attachment 140642)
View in context: https://bugs.webkit.org/attachment.cgi?id=140642&action=review

Sorry, needs one more iteration :)

> Source/WebKit/blackberry/WebCoreSupport/AutofillManager.cpp:31
> +static bool isNotAutofillable(HTMLInputElement* element)

I think this is better to reverse this logic, ie. make it isAutofillable, and test for ! isNotAutofillable().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.