[Webkit-unassigned] [Bug 85576] [BlackBerry] AutofillManager implementation upstream

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=85576


Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #140625|review?                     |review-
               Flag|                            |




--- Comment #6 from Rob Buis <rwlbuis at gmail.com>  2012-05-07 17:44:52 PST ---
(From update of attachment 140625)
View in context: https://bugs.webkit.org/attachment.cgi?id=140625&action=review

Looks good, can be improved some more.

> Source/WebKit/blackberry/WebCoreSupport/AutofillManager.cpp:45
> +    Vector<String> candidates = autofillBackingStore().get(element->getAttribute("name").string(), element->value());

Can you use HTMLNames::nameAttr here? Also is this line needed since you are not using candidates.

> Source/WebKit/blackberry/WebCoreSupport/AutofillManager.cpp:66
> +            || element->isAutofilled() || !element->shouldAutocomplete())

You are doing these checks here and in didChangeInTextField, can you make a static function for this in this .cpp?

> Source/WebKit/blackberry/WebCoreSupport/AutofillManager.cpp:68
> +        autofillBackingStore().add(element->getAttribute("name").string(), element->value());

Can you use HTMLNames::nameAttr here?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.