[Webkit-unassigned] [Bug 85576] [BlackBerry] AutofillManager implementation upstream

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=85576





--- Comment #4 from Jonathan Dong <jonathan.dong at torchmobile.com.cn>  2012-05-07 17:03:21 PST ---
(In reply to comment #3)
> (From update of attachment 140460 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=140460&action=review
> 
> >> Source/WebKit/blackberry/WebCoreSupport/AutofillManager.h:37
> >> +class HTMLInputElement;
> > 
> > The whole block in namespace should be indented.
> 
> Thanks Rob, for those indentation things, I guess many of our porting's codes are not following this guideline, especially in WebKit/blackberry. Do we need to fix them when we are about to make some changes?
> Anyway I'll follow your suggestion with my next patch.

oh, the changes with the indentation in namespace are rejected by check-webkit-style, and I also checked the coding style of webkit.org in http://www.webkit.org/coding/coding-style.html which implies that we should not indent in this situation.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.