[Webkit-unassigned] [Bug 85844] Inline Node::traverseNextNode

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=85844





--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org>  2012-05-07 16:54:24 PST ---
(From update of attachment 140621)
View in context: https://bugs.webkit.org/attachment.cgi?id=140621&action=review

> Source/WebCore/dom/Node.h:861
> +    const Node* n = this;

Please spell out node.

> Source/WebCore/dom/Node.h:869
> +inline Node* Node::traverseNextNode(const Node* stayWithin) const

Should we use template to share the code?

> Source/WebCore/dom/Node.h:877
> +    const Node* n = this;

Ditto about one-letter variable name.

> Source/WebCore/dom/Node.h:878
> +    while (n && !n->nextSibling() && (!stayWithin || n->parentNodeAsNode() != stayWithin))

It appears to me that we should call traverseNextNode() when stayWithin is 0.

> Source/WebCore/dom/Node.h:889
> +    const Node* n = this;

Ditto about one-letter variable name.

> Source/WebCore/dom/Node.h:903
> +    const Node* n = this;

Ditto about one-letter variable name.

> Source/WebCore/dom/Node.h:904
> +    while (n && !n->nextSibling() && (!stayWithin || n->parentNodeAsNode() != stayWithin))

Ditto about calling traverseNextSibling() instead.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.