[Webkit-unassigned] [Bug 85670] [BlackBerry] Implement a popup client for HTML controls

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=85670


Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #140589|review?                     |review-
               Flag|                            |




--- Comment #6 from Rob Buis <rwlbuis at gmail.com>  2012-05-07 14:25:33 PST ---
(From update of attachment 140589)
View in context: https://bugs.webkit.org/attachment.cgi?id=140589&action=review

Looks good, can still be cleaned up a bit.

> Source/WebKit/blackberry/WebCoreSupport/WebPopupImpl.cpp:50
> +

Can remove the empty line.

> Source/WebKit/blackberry/WebCoreSupport/WebPopupImpl.cpp:133
> +

Can remov the empty line here.

> Source/WebKit/blackberry/WebCoreSupport/WebPopupImpl.cpp:233
> +    case WebCore::PlatformEvent::MouseReleased:

Can remove all WebCore:: prefixes in this method.

> Source/WebKit/blackberry/WebCoreSupport/WebPopupImpl.cpp:252
> +    if (m_page) {

Can early return here if !page.

> Source/WebKit/blackberry/WebCoreSupport/WebPopupImpl.cpp:258
> +    m_page.clear();

Better use m_page->clear();

> Source/WebKit/blackberry/WebCoreSupport/WebPopupImpl.h:24
> +

Can remove empty line here.

> Source/WebKit/blackberry/WebCoreSupport/WebPopupImpl.h:54
> +

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.