[Webkit-unassigned] [Bug 74921] [EFL] Add new commands for Ewk_Editor_Command.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=74921





--- Comment #27 from Raphael Kubo da Costa (rakuco) <rakuco at webkit.org>  2012-05-07 08:14:41 PST ---
(In reply to comment #26)
> > Note that this approach "leaks" as much as using a static raw pointer -- even if you do call the OwnPtr destructor, it will be done at the program shutdown anyway. I guess that's why this idiom is not found elsewhere in the code base, by the way.
> 
> I just thought that it will be better to clean up after myself by calling eina_hash_free explicitly than leaving it unfreed as we destroy the application.

In practice this will make no difference, and WebKit itself already does that in many other places, including WebCore. The patch size could be reduced a bit if you just leak the raw pointer, and you wouldn't need to depend on the Eina_Hash OwnPtr bug to land this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.